Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/herald rule" without parameter
ClosedPublic

Authored by aklapper on Tue, Apr 16, 08:45.
Tags
None
Referenced Files
F2191731: D25585.1715807364.diff
Tue, May 14, 21:09
Unknown Object (File)
Tue, May 7, 17:56
Unknown Object (File)
Tue, May 7, 07:09
Unknown Object (File)
Tue, May 7, 01:54
Unknown Object (File)
Sun, May 5, 23:30
Unknown Object (File)
Sun, May 5, 23:30
Unknown Object (File)
Sun, May 5, 23:30
Unknown Object (File)
Sun, May 5, 03:48

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/herald/management/HeraldRuleManagementWorkflow.php:36]
Test Plan

Run ../phorge/bin/herald rule: Get no strlen() error anymore but only expected output Usage Exception: Specify a rule to edit with "--rule <id|monogram>".

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable