Paths

Table of Contentst

Differential D25567

Fix PHP 8.1 "preg_match(null)" exception exporting task list to CSV
ClosedPublic
Actions

Authored by aklapper on Apr 2 2024, 20:31.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 4, 14:24

	Unknown Object (File)
	Sat, May 4, 14:24

	Unknown Object (File)
	Sat, May 4, 13:25

	Unknown Object (File)
	Sat, May 4, 12:29

	Unknown Object (File)
	Fri, Apr 26, 20:11

	Unknown Object (File)
	Wed, Apr 17, 18:27

	Unknown Object (File)
	Wed, Apr 17, 07:14

	Unknown Object (File)
	Apr 11 2024, 02:21

View All 23 Files

Subscribers

valerio.bozzolan

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15770: PHP 8.1 "preg_match(null)" exception exporting task list to CSV

Commits

rPc0bc45340584: Fix PHP 8.1 "preg_match(null)" exception exporting task list to CSV

Summary

When a column value to export to CSV is empty, null is passed to preg_match() which is deprecated behavior since PHP 8.1.
Thus only call preg_match() when the value is set.

ERROR 8192: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/export/format/PhabricatorCSVExportFormat.php:51]

ERROR 8192: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/export/format/PhabricatorCSVExportFormat.php:55]

Closes T15770

Test Plan

Export a Maniphest task list of query results to CSV.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Apr 2 2024, 20:31

Owners added a reviewer: O1: Blessed Committers.Apr 2 2024, 20:31

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptApr 2 2024, 20:31

aklapper requested review of this revision.Apr 2 2024, 20:31

Harbormaster completed remote builds in B1142: Diff 1811.Apr 2 2024, 20:31

20after4 accepted this revision.Apr 3 2024, 00:50

This revision is now accepted and ready to land.Apr 3 2024, 00:50

Closed by commit rPc0bc45340584: Fix PHP 8.1 "preg_match(null)" exception exporting task list to CSV. · Explain WhyApr 3 2024, 09:57

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPc0bc45340584: Fix PHP 8.1 "preg_match(null)" exception exporting task list to CSV.

Revision Contents
Changeset List

Path

Size

Packages

src/

infrastructure/

export/

format/

PhabricatorCSVExportFormat.php

4 lines

O1: Blessed Committers

Diff 1819

src/infrastructure/export/format/PhabricatorCSVExportFormat.php

Loading...