Odd, I can't quite figure out how this would interfere with //Optional list<string>.//

I think the current syntax should be ok because it isn't normal to use {} around a project name. And my regex only matches exactly 3 or 6 hex digits, as demonstrated in the hex-color-code.txt test file.

Trusted Contributors membership granted.

Good question.

@Jack_who_built_the_house This is one of the things that always frustrated me with Wikimedia projects, there is a tendency to discourage doing something new or trying something experimental. Instead of just putting it out there and letting it either succeed or fail based on the merits, there is a lot of bureaucracy around consensus building. Sadly it's just the way things are with a community/organization as large and as socialistic as Wikimedia has become.

I think ponder is sort of a minimal viable product state currently. It lacks some features like putting questions on workboards and there just aren't many
(or any?) integrations with the rest of Phorge. That wouldn't take much effort to improve it, most likely.

Also apologies for not testing this locally in the phab ui, I was far too confident in my TDD.

man I didn't even consider that you could actually have a valid project named #0dba11 ... maybe the syntax should be something different. #{00ffff} perhaps?

It's kind of a shame that remarkup wasn't named Pharkup.

Actually add the rule to the remarkup engine.

LOL I only ever tested the unit test case. I forgot to add the rule to PhabricatorMarkupEngine:

In T15670#15501, @avivey wrote:

Thinking more, I think we'd like to allow the robots to index latest version of the code - these days the big boys know how to handle that. Stopping them from crawling older versions is still important.

Anyway, I vote to revert the change - commit pages can have discussions in.

If it's that easy, then I'm both impressed and surprised it remained this way for so long. I'm actually not quite sure I understand the reasoning for not using # to begin with.

Address review feedback:

I'll test this locally, I can't see any reason we shouldn't merge it.

This D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes should be ready to merge now, if someone wouldn't mind reviewing it.

Discussed on IRC: it seems that this should have been POST all along.

In D25540#16124, @valerio.bozzolan wrote:

About your Remarkup unit tests, try to rebase. Maybe related to D25559.

• Fixed a logic bug.
• Added passing unit tests.

So I got this mostly working locally, it's actually fairly trivial to reuse the existing token storage and infrastructure. Actually displaying the tokens might not be the most efficient of operations when there are a lot of comments on a given object. I still need to write an optimized query to fetch all of the token given in one query rather than many and then figure out how to display the tokens inline with the comments.

@littleggghost I think you might just need to run celerity to update the icons.

This is really cool!

Added documentation in D25547: Diviner: Improve documentation for remarkup code blocks

Awesome! I'm glad it finally worked. If you want all of your tasks to have the 'deadline' subtype you can edit your task form to set the subtype (or create a separate form that sets the subtype) that way you don't have to manually change the type of each task after it's created.

Did you manage to get the extension working?

You still need the wikimedia extension at least for now. The screenshots just show how to change the subtype of a task and then shows the due date icon. I just changed the permissions on the attachments, maybe they work now?

@littleggghost: Yes after applying the patch to phorge master branch I can see the icon.

confirmed, that warning makes no sense.

Hahah I guess I could have tested it first.

This looks correct to me:

I agree, badges seems like the right way to go. They are an underutilized feature really, IMO.

@littleggghost So it turns out that in order to enable this feature, there was a patch to Phabricator core. That patch isn't part of the wikimedia extension, and hasn't been merged into phorge.

@littleggghost one thing you might want to try is updating the celerity map. You may be missing the custom css rules to style the deadline appropriately. I’m not familiar enough with the phorge docker image to be able to tell you exactly how that is accomplished. With non-containerized phorge instances you would just run bin/celerity map from within the phorge root directory.

In T15743#15855, @valerio.bozzolan wrote:

• https://github.com/xemlock/php-latex (PHP server side)

Interestingly, I just discovered Wikimedia has a pretty cool project to render math on the server side, by transpiling some js into php:

I went down a rabbit hole while trying to add unit tests for this. Our core remarkup unit tests are pretty thorough but they only seem to cover the "core" remarkup engine and syntax. When I added a new test case for this it would pass but always caused a different test case to fail in weird ways. I haven't yet figured out what part of the unit test or engine is stateful such that my unit test alters the state in a way that breaks a later test. If I change the order that tests run in, it just causes another different test case to fail.

Fix lint again

fix lint.

Added contrasting color calculation

There is also MathJax, a subset of LaTex that only covers the mathematical notation without the page layout functionality.

This is not yet tested.

fix lint error.

This would be useful for discussions about design, specifically I wished for this feature while reviewing D25491: Improve contrast of Links in Dark Mode